mathieu/dash
1
0
Fork 0
Code Issues Pull requests Releases 8 Activity Actions

Make overlay shift test hermetic #10

Merged
mathieu merged 1 commit from lain/fix-overlay-test-hermetic-20261103000330 into main 2026-11-02 23:05:31 +00:00
Conversation 0 Commits 1 Files changed 1 +1
Lain commented 2026-11-02 23:04:04 +00:00
Collaborator
Copy link

TestShiftOpensWindowOnlyWithTmux did not set up fake tools, so it depended on podman being on PATH. On CI (golang image without podman) the menu showed 'not found' and the shell never opened, failing the main test job.

Adds withTools(t) like the neighbouring tests. Verified: fails without the change and passes with it when podman is absent from PATH; full overlay package passes.

TestShiftOpensWindowOnlyWithTmux did not set up fake tools, so it depended on podman being on PATH. On CI (golang image without podman) the menu showed 'not found' and the shell never opened, failing the main test job. Adds withTools(t) like the neighbouring tests. Verified: fails without the change and passes with it when podman is absent from PATH; full overlay package passes.
Make overlay shift test hermetic
All checks were successful
ci / test (pull_request) Successful in 1m13s
Details
9464314a17 
TestShiftOpensWindowOnlyWithTmux did not set up fake tools, so it
depended on podman being on PATH. On CI, where podman is absent, the
menu showed 'not found' and the shell never opened.
mathieu deleted branch lain/fix-overlay-test-hermetic-20261103000330 2026-11-02 23:05:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
mathieu/dash!10
No description provided.